Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update typing for copy #139

Merged
merged 2 commits into from
Dec 5, 2024
Merged

update typing for copy #139

merged 2 commits into from
Dec 5, 2024

Conversation

spyinx
Copy link
Contributor

@spyinx spyinx commented Dec 5, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

destination_db param in copy() method supports integer, so we can change the type constraint for it
fix: #138

@mkmkme
Copy link
Collaborator

mkmkme commented Dec 5, 2024

Could you please address the DCO check? https://github.com/valkey-io/valkey-py/pull/139/checks?check_run_id=33966562917

@spyinx spyinx force-pushed the fix-copy-param-typing branch from b6b7173 to 2536ba0 Compare December 5, 2024 11:11
@spyinx
Copy link
Contributor Author

spyinx commented Dec 5, 2024

Could you please address the DCO check? https://github.com/valkey-io/valkey-py/pull/139/checks?check_run_id=33966562917

sorry, i'm not familiar with the process here，since someone is working on fixing type hints (see #138) and you think it's useless, you can close this pr, thank you !

@mkmkme
Copy link
Collaborator

mkmkme commented Dec 5, 2024

I don't think this is useless, and we welcome all the good contributions and new contributors :)

Your second commit contains the needed Signed-off-by line, but the first one still doesn't. If you visit this link it will show you the commands needed to fix it.

@spyinx spyinx force-pushed the fix-copy-param-typing branch from 2536ba0 to ecf83e5 Compare December 5, 2024 13:08
@aiven-sal aiven-sal force-pushed the fix-copy-param-typing branch from ecf83e5 to 8af8b4a Compare December 5, 2024 15:37
mkmkme
mkmkme approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mkmkme mkmkme enabled auto-merge December 5, 2024 15:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (1eec818) to head (8af8b4a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files         130      130           
  Lines       33907    33907           
=======================================
  Hits        25837    25837           
  Misses       8070     8070

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-sal aiven-sal removed the maintenance dependabot PR's label Dec 5, 2024
@mkmkme mkmkme merged commit 8d9470d into valkey-io:main Dec 5, 2024
93 checks passed
@spyinx spyinx deleted the fix-copy-param-typing branch December 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiven-sal aiven-sal aiven-sal approved these changes

@mkmkme mkmkme mkmkme approved these changes

@ahmedsobeh ahmedsobeh Awaiting requested review from ahmedsobeh ahmedsobeh is a code owner

Assignees
No one assigned
Labels
not-for-changelog typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change destination_db's type constraint in copy() method ?
4 participants
@spyinx @mkmkme @codecov-commenter @aiven-sal